Back to the Vavoom Forum Archives


Forum

[Fixed] (Probably) incorrect behavior of svnrevision tool

Tue, 22 Sep 2009 10:34:40

mnk

Issue 1: I'm not sure if this was desired, but svnrevision checks only the version of source/ subdir, not the whole svn tree - i.e. that means revision number didn't changed between 4074 and 4075 (on one hand, now version doesn't change, if only tools were updated, but on the other, vc files under progs/ don't update it too) Issue 2: as vcc uses headers from source/ subdir, that include svnrevision generated header, if that header is updated, on a second make run after 'svn up', vcc is rebuilt, because that header was updated - it should be rebuild on the first run; I think adding the same custom target as in sorce/ to utils/vcc/ (or a dependency on that one) should fix it.
Thu, 24 Sep 2009 11:58:45

Firebrand

VCC is not supposed to use the updaterevision header file, that one is only used by the main executable... which makes me think this problem is weird. If you did a fix for this, could you post it here to check it out?
Fri, 25 Sep 2009 10:56:35

mnk

Of course it does include it - vavoom has a very poor design when it comes to including headers: nearly everything includes nearly everything else. In this particular case, the chain goes: svnrev.h -> gamedefs.h -> vc_local.h . Perhaps (haven't tested), putting '#include "svnrev.h"' in gamedefs.h inside '#ifndef IN_VCC' could help. Still, about the other part: does that mean that not tracking changes in vc files is on purpose - it SHOULD track just the source/ subdir changes ? Oh, and any suggestions about testing that gcc problem from the other thread ?
Fri, 16 Oct 2009 11:44:13

Firebrand

OK, I made some changes to this, let me know if things work fine now.

Back to the Vavoom Forum Archives